Skip to content

feat: support ES6 Map and Set for regular validators with each option - #430

Merged
vlapo merged 1 commit into
typestack:masterfrom
vlapo:better-support-map-set
Oct 14, 2019
Merged

vlapo merged 1 commit into
typestack:masterfrom
vlapo:better-support-map-set

Conversation

@vlapo

@vlapo vlapo commented Oct 2, 2019

Copy link
Copy Markdown
Contributor

Looks like we do not support each option for Map and Set (#428)

This PR add support Map/Set for regular validators and custom validators @Validate.

Also small unit tests added.

Close #428

@vlapo

vlapo commented Oct 2, 2019

Copy link
Copy Markdown
Contributor Author

@henrikra and @rubiin as active contributors please review. All reviews are welcome.

@rubiin

rubiin commented Oct 3, 2019

Copy link
Copy Markdown
Contributor

Had a look at the code, doesn't seem to have any bugs so far @vlapo

@vlapo
vlapo merged commit a055bba into typestack:master Oct 14, 2019
@vlapo
vlapo deleted the better-support-map-set branch October 14, 2019 09:43
@github-actions

github-actions Bot commented Aug 4, 2020

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Map validation like in the examples doesn't seem to work

2 participants